community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

feat: deep link into impact section in settings page

Open paposeco opened this issue 2 months ago • 1 comments

PR Checklist

PR Type

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Developer experience (improves developer workflows for contributing to the project)

Description

It is now possible to link to the Impact section on the Settings page, for a given year. By adding ?section=impact."wantedyear" to the /settings url, the Impact section is expanded and the user is taken to the provided year. If impact data is missing from a user's profile, by clicking on the "Edit data" from the profile, the user will also be taken straight to the right place on the settings page.

(for example: /settings?section=impact.2022 will take you to the 2022 Impact section on the settings page)

Git Issues

Closes # 3055

paposeco avatar Apr 22 '24 16:04 paposeco

Passing run #5537 ↗︎

0 80 1 0 Flakiness 0

Details:

Merge branch 'master' into 3055-deep-link-impact-section
Project: onearmy-community-platform Commit: 9aca49eeca
Status: Passed Duration: 04:11 💡
Started: May 9, 2024 10:05 AM Ended: May 9, 2024 10:10 AM

Review all test suite changes for PR #3471 ↗︎

cypress[bot] avatar Apr 22 '24 16:04 cypress[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.49%. Comparing base (3b61ab9) to head (9aca49e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3471      +/-   ##
==========================================
- Coverage   74.70%   67.49%   -7.22%     
==========================================
  Files          34      433     +399     
  Lines        1115    13707   +12592     
  Branches      249     2467    +2218     
==========================================
+ Hits          833     9252    +8419     
- Misses        259     4409    +4150     
- Partials       23       46      +23     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 10:05 codecov[bot]

Awesome! Thanks @paposeco!

benfurber avatar May 09 '24 12:05 benfurber

:tada: This PR is included in version 1.180.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar May 10 '24 10:05 onearmy-bot