community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

feat(questions): Add some feature tests

Open benfurber opened this issue 3 months ago • 2 comments

PR Checklist

PR Type

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] Developer experience (improves developer workflows for contributing to the project)

Description

It's felt uncomfortable working on the Questions module without feature tests I could understand and use. This starts adding them - happy path for creating/updating a new question.

benfurber avatar Mar 20 '24 15:03 benfurber

Passing run #5326 ↗︎

0 99 0 0 Flakiness 0

Details:

feat: add question read tests
Project: onearmy-community-platform Commit: 6c5b0f8ed2
Status: Passed Duration: 05:03 💡
Started: Mar 25, 2024 1:39 PM Ended: Mar 25, 2024 1:44 PM

Review all test suite changes for PR #3375 ↗︎

cypress[bot] avatar Mar 20 '24 15:03 cypress[bot]

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 65.89%. Comparing base (d7eaa82) to head (4d22155).

:exclamation: Current head 4d22155 differs from pull request most recent head 6c5b0f8. Consider uploading reports for the commit 6c5b0f8 to get more accurate results

Files Patch % Lines
src/pages/Question/QuestionPage.tsx 50.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3375      +/-   ##
==========================================
+ Coverage   65.79%   65.89%   +0.09%     
==========================================
  Files         416      411       -5     
  Lines       13450    13323     -127     
  Branches     2478     2441      -37     
==========================================
- Hits         8850     8779      -71     
+ Misses       4548     4492      -56     
  Partials       52       52              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 20 '24 18:03 codecov[bot]

:tada: This PR is included in version 1.165.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Mar 27 '24 11:03 onearmy-bot