community-platform
community-platform copied to clipboard
refactor: replace tag components across how-to and research
PR Checklist
- [ ] - Commit messages are descriptive, it will be used in our Release Notes
PR Type
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Developer experience (improves developer workflows for contributing to the project)
Description
Refactoring of components using tagList as described in the issues ticket.
Git Issues
Closes #3357
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform development
channel.
Thanks for this @simontree. I think this needs to go further. The idea is that no tagList needs to be set to any content type.
<content>.tags
should be fine to give to TagList without any faff.
Hey @benfurber - sorry, I was working on some other things. Also, I am new to open source issues. Is there any time you suggest until this ticket should be solved ideally? Also I would be interested in joining the monthly dev call if thats okay? If yes, what would be the next time you guys are meeting up?
All the best!
Visit the preview URL for this PR (updated for commit b1daca6):
https://onearmy-next--pr3367-3357-replace-tag-com-ru3uthq0.web.app
(expires Sat, 27 Apr 2024 10:09:12 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59
Hey @simontree. Did you mean to close the PR?
Hey @simontree. Did you mean to close the PR?
sorry - this happened by accident after testing to get git worktree working on my end - will create a new PR - pls check out this new one - https://github.com/ONEARMY/community-platform/pull/3400