fix: actually limit tags to four

[simontree]

PR Checklist

• [ ] - Commit messages are descriptive, it will be used in our Release Notes

PR Type

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Developer experience (improves developer workflows for contributing to the project)

Description

Fixes the issue of being able to select more than four tags with a short errortext.

Git Issues

Closes [#3347]

Screenshot

---

What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 64.91%. Comparing base (9ca4c50) to head (2acaea0). Report is 12 commits behind head on master.

Files	Patch %	Lines
src/common/Tags/TagsSelect.tsx	33.33%	8 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3365      +/-   ##
==========================================
- Coverage   64.92%   64.91%   -0.01%     
==========================================
  Files         404      404              
  Lines       13210    13218       +8     
  Branches     2406     2410       +4     
==========================================
+ Hits         8577     8581       +4     
- Misses       4581     4585       +4     
  Partials       52       52              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[cypress[bot]]

Passing run #5293 ↗︎

0

96

0

0

0

Details:

fix: actually limit tags to four
Project: onearmy-community-platform	Commit: 2acaea0c44
Status: Passed	Duration: 04:18 💡
Started: Mar 16, 2024 12:18 PM	Ended: Mar 16, 2024 12:22 PM

Review all test suite changes for PR #3365 ↗︎