community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

chore(deps): upgrade firebase-tools to v13

Open thisislawatts opened this issue 6 months ago • 3 comments

PR Checklist

PR Type

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [X] Developer experience (improves developer workflows for contributing to the project)

Description

The only breaking changes in this version do seem related to our use

  • Breaking: dropped support for running the CLI on Node.js v16.
  • Breaking: Refactored functions:shell to remove dependency on deprecated request module. As part of this change, removed support for some rarely used features of request.
  • Breaking: Removed deprecated ext:dev:publish command. Use ext:dev:upload instead.

https://github.com/firebase/firebase-tools/releases

Outstanding:

  • [ ] Verify whether we need to rebuild docker image for local development with emulator.

thisislawatts avatar Jan 06 '24 17:01 thisislawatts

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.56%. Comparing base (7e8ac3e) to head (3b7f4b4). Report is 249 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3162   +/-   ##
=======================================
  Coverage   62.55%   62.56%           
=======================================
  Files         372      372           
  Lines       11933    11933           
  Branches     2160     2160           
=======================================
+ Hits         7465     7466    +1     
+ Misses       4417     4416    -1     
  Partials       51       51           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 06 '24 17:01 codecov[bot]

1 flaky test on run #4942 ↗︎

0 96 0 0 Flakiness 1

Details:

chore(deps): upgrade firebase-tools to v13
Project: onearmy-community-platform Commit: 3b7f4b4578
Status: Passed Duration: 04:29 💡
Started: Jan 6, 2024 5:24 PM Ended: Jan 6, 2024 5:29 PM
Flakiness  src/integration/research/follow.spec.ts • 1 flaky test • ci-chrome

View Output

Test Artifacts
[Research] > [By Authenticated] > [Follow button] Screenshots

Review all test suite changes for PR #3162 ↗︎

cypress[bot] avatar Jan 06 '24 17:01 cypress[bot]

Is there a reason not to get this merged?

benfurber avatar Feb 26 '24 16:02 benfurber