community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

[DRAFT] fix: update user delete procedure

Open iSCJT opened this issue 1 year ago • 3 comments

trying a function that triggers when the auth record is deleted to get round permission denied error

#1412

PR Checklist

PR Type

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Developer experience (improves developer workflows for contributing to the project)

Description

What this PR does

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

iSCJT avatar Jun 13 '23 15:06 iSCJT

Visit the preview URL for this PR (updated for commit 01340f0):

https://onearmy-next--pr2419-1412-bug-deleting-us-b6ntn8xh.web.app

(expires Thu, 13 Jul 2023 15:47:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59

github-actions[bot] avatar Jun 13 '23 15:06 github-actions[bot]

Codecov Report

Patch coverage has no change and project coverage change: -0.24 :warning:

Comparison is base (fbe1b3d) 44.65% compared to head (01340f0) 44.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2419      +/-   ##
==========================================
- Coverage   44.65%   44.41%   -0.24%     
==========================================
  Files         253      253              
  Lines        6873     6871       -2     
  Branches     1525     1525              
==========================================
- Hits         3069     3052      -17     
- Misses       3775     3787      +12     
- Partials       29       32       +3     
Impacted Files Coverage Δ
src/stores/User/user.store.ts 1.89% <ø> (+0.02%) :arrow_up:

... and 7 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 13 '23 15:06 codecov[bot]

2 flaky tests on run #3605 ↗︎

0 90 0 0 Flakiness 2

Details:

fix: update user delete procedure
Project: onearmy-community-platform Commit: 01340f04c5
Status: Passed Duration: 04:32 💡
Started: Jun 13, 2023 3:49 PM Ended: Jun 13, 2023 3:54 PM
Flakiness  research/write.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Research] > [Edit a research article] > [By Owner] Output Screenshots
Flakiness  map.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
map > [By User] > should show the user a message stating their pin is rejected Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

cypress[bot] avatar Jun 13 '23 15:06 cypress[bot]

Closing as approach didn't work

iSCJT avatar Jun 27 '23 15:06 iSCJT