community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

[draft] chore: add eslint import sort

Open iSCJT opened this issue 1 year ago • 3 comments

PR Checklist

PR Type

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] Developer experience (improves developer workflows for contributing to the project)

Description

Adds eslint config for sorting imports + initial changes after a format run

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

iSCJT avatar May 10 '23 20:05 iSCJT

@iSCJT it looks like this PR needs some formatting applied. I wonder if there could be a conflict between the eslint and prettier rules?

thisislawatts avatar May 13 '23 19:05 thisislawatts

Yea I was going to sort that and a couple of others this afternoon but only just got back to kamp. Will get it resolved in the morning.

iSCJT avatar May 13 '23 19:05 iSCJT

@iSCJT sounds great, no urgency from my side :)

thisislawatts avatar May 13 '23 20:05 thisislawatts

Seems quite a little time has passed and this has become stale, what do you want to do here @iSCJT?

AlfonsoGhislieri avatar Jun 26 '23 13:06 AlfonsoGhislieri

Thanks for prod @AlfonsoGhislieri 👍

I've closed it. Will come back to it another time.

iSCJT avatar Jun 26 '23 13:06 iSCJT