community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

feat(components): new VideoPlayer, supports Vimeo/Youtube and more

Open thisislawatts opened this issue 1 year ago • 1 comments

PR Checklist

PR Type

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [X] Developer experience (improves developer workflows for contributing to the project)

Description

Move from direct usage of react-player to use VideoPlayer component.

Also:

  • Updates react-player to latest version

thisislawatts avatar Apr 01 '23 12:04 thisislawatts

2 flaky tests on run #3751 ↗︎

0 90 0 0 Flakiness 2

Details:

chore: formatting
Project: onearmy-community-platform Commit: 0a8287d9c4
Status: Passed Duration: 04:09 💡
Started: Jun 30, 2023 10:47 AM Ended: Jun 30, 2023 10:51 AM
Flakiness  research/write.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Research] > [Edit a research article] > [By Owner] Output Screenshots
Flakiness  common.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Common] > [User Menu] > [By Authenticated] Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

cypress[bot] avatar Apr 01 '23 16:04 cypress[bot]

Codecov Report

Patch coverage: 94.59% and project coverage change: +0.29 :tada:

Comparison is base (1cea54c) 44.69% compared to head (0a8287d) 44.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2196      +/-   ##
==========================================
+ Coverage   44.69%   44.98%   +0.29%     
==========================================
  Files         263      265       +2     
  Lines        7319     7354      +35     
  Branches     1621     1625       +4     
==========================================
+ Hits         3271     3308      +37     
+ Misses       4018     4017       -1     
+ Partials       30       29       -1     
Impacted Files Coverage Δ
src/pages/Howto/Content/Howto/Step/Step.tsx 71.42% <0.00%> (ø)
src/pages/Research/Content/ResearchUpdate.tsx 72.22% <0.00%> (ø)
...components/src/VideoPlayer/VideoPlayer.stories.tsx 100.00% <100.00%> (ø)
...ackages/components/src/VideoPlayer/VideoPlayer.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 30 '23 10:06 codecov[bot]

:tada: This PR is included in version 1.70.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Jun 30 '23 22:06 onearmy-bot

Closes #2558

iSCJT avatar Jul 04 '23 16:07 iSCJT