community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

chore: enforce sorting on class attributes

Open thisislawatts opened this issue 2 years ago β€’ 1 comments

  • chore(deps): introduces eslint sort rule
  • chore(formatting): apply sort order rule to classes

PR Checklist

PR Type

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] Developer experience (improves developer workflows for contributing to the project)

Description

ESLint rule for enforcing consistent ES6 class member order. https://github.com/bryanrsmith/eslint-plugin-sort-class-members

Because we shouldn't expect humans to care too much about this πŸ‘ΌπŸ»

thisislawatts avatar Oct 16 '22 09:10 thisislawatts



Test summary

47 β€’ 0 β€’ 0 β€’ 0 β€’ Flakiness 0


Run details

Project onearmy-community-platform
Status Passed
Commit b3b92427b4
Started Oct 22, 2022 9:44 PM
Ended Oct 22, 2022 9:47 PM
Duration 02:49 πŸ’‘
OS Linux Ubuntu - 20.04
Browser Chrome 106

View run in Cypress Dashboard ➑️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Oct 16 '22 09:10 cypress[bot]

:tada: This PR is included in version 1.29.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Oct 23 '22 11:10 onearmy-bot