community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

Published 20 hours ago • verified publisher icon ONEARMY

[bug] Wrong Icon size on Fixing Fashion Map

Open davehakkens opened this issue 2 years ago • 10 comments

Describe the bug The icons on the map of Fixing Fashion are not correct. The icons shown are for large display size, but they should be for small display size.

To Reproduce Steps to reproduce the behaviour:

  1. Go to https://community.fixing.fashion/map
  2. See the icons

Expected behaviour

  1. Space icon should be: https://github.com/ONEARMY/community-platform/blob/master/src/assets/images/themes/fixing-fashion/avatar_space.svg

  2. Member icon should be: https://github.com/ONEARMY/community-platform/blob/master/src/assets/images/themes/fixing-fashion/avatar_member.svg

Screenshots FF-map-icons

Additional context Add any other context about the problem here

davehakkens avatar Sep 25 '22 16:09 davehakkens

@davehakkens I can take this.

asheerrizvi avatar Sep 30 '22 12:09 asheerrizvi

great. thanks!

davehakkens avatar Oct 01 '22 14:10 davehakkens

Would be cool to try and get this done before Thursday @asheerrizvi if possible. Sharing a Patreon article about it. :)

davehakkens avatar Oct 04 '22 22:10 davehakkens

hey @davehakkens this should be done for all screen sizes right?

asheerrizvi avatar Oct 05 '22 09:10 asheerrizvi

yes.

davehakkens avatar Oct 05 '22 09:10 davehakkens

Got you, it's somewhat tricky. Currently, the codebase uses src/modules/profile/SupportedProfileTypesFactory.ts to fetch the type of icons it shows on the map. And all of them are generic icons. We will have to come up with a way to show theme based icons instead.

asheerrizvi avatar Oct 05 '22 09:10 asheerrizvi

@davehakkens here's what I was able to come up with:

https://github.com/ONEARMY/community-platform/pull/1978

asheerrizvi avatar Oct 05 '22 10:10 asheerrizvi

Hmm but it seems to already show correct on the Precious Plastic Instance.. Or because it doesnt use theming?

davehakkens avatar Oct 05 '22 10:10 davehakkens

Yea that's because it is not using theming.

asheerrizvi avatar Oct 05 '22 10:10 asheerrizvi

It is using pt-member badge there which is basically this:

image

Similar thing is happening in Project Kamp as well.

asheerrizvi avatar Oct 05 '22 10:10 asheerrizvi

:tada: This issue has been resolved in version 1.29.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Oct 23 '22 11:10 onearmy-bot

:tada: This issue has been resolved in version 1.31.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Nov 26 '22 23:11 onearmy-bot