community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

Fixes link styles for research and how-to articles

Open asheerrizvi opened this issue 2 years ago • 3 comments

PR Checklist

PR Type

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Developer experience (improves developer workflows for contributing to the project)

Description

Link styles for research & how-to articles.

Git Issues

Closes #1846

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on slack in the platform-dev channel.

asheerrizvi avatar Aug 14 '22 15:08 asheerrizvi

Visit the preview URL for this PR (updated for commit 3a92a08):

https://onearmy-next--pr1891-fix-1846-olz6a0em.web.app

(expires Fri, 16 Sep 2022 06:04:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot] avatar Aug 14 '22 20:08 github-actions[bot]

hey @asheerrizvi thanks man 🤘 this works as expected 💪 As you're at it could you please add an hover state where the underline gets removed?

Big up!

thisismattia avatar Aug 15 '22 07:08 thisismattia

Thanks @asheerrizvi for finding a solution to the :hover state. Behaves nicely. Thank you ✌️ Over to the maintainers to merge :)

thisismattia avatar Aug 15 '22 11:08 thisismattia



Test summary

59 0 0 0Flakiness 0


Run details

Project onearmy-community-platform
Status Passed
Commit 3a92a08416
Started Aug 17, 2022 5:29 AM
Ended Aug 17, 2022 5:33 AM
Duration 03:13 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 17 '22 05:08 cypress[bot]

:tada: This PR is included in version 1.20.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Aug 17 '22 05:08 onearmy-bot