community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

[bug] Change inline link colour

Open thisismattia opened this issue 2 years ago • 10 comments

Issue: Inline links (maybe all links) seem to be set to browser default colours which looks.. well.. defaulty. Also the "visited" state to purple looks so unloved :)

Link: https://community.preciousplastic.com/

Screenshots: Screenshot_2022-07-23_at_15_18_22

Proposal: we set links to { color: grey; text-decoration: underline; }

:hover { underline: none; } :visited { color: grey; text-decoration: underline; }

Screenshot 2022-07-23 at 15 19 47

thisismattia avatar Jul 23 '22 13:07 thisismattia

I'm interested in taking on this one. First time looking at/contributing to the codebase, but I'm excited to learn :)

Connor-McMillin avatar Jul 26 '22 16:07 Connor-McMillin

I might need a bit of guidance on making this change.

I attempted to stylize Linkify within src/pages/Howto/Content/Howto/HowtoDescription and wasn't able to find a way to stylize the links with hover and visited. I also saw the global style which allowed me to style those links (and every other link on the site). I don't know if this change should be made at the precious-plastic theme level or on the individual howto pages shown above.

Connor-McMillin avatar Jul 26 '22 21:07 Connor-McMillin

Hey @Connor-McMillin nice one, thanks for taking this issue :) @davehakkens any ideas who could be the best person to point Connor to for this?

thisismattia avatar Jul 27 '22 06:07 thisismattia

Thanks for askin @Connor-McMillin, the style should be changed for all body text on Research and how-to pages.

davehakkens avatar Jul 27 '22 06:07 davehakkens

@Connor-McMillin hey are you still working on this?

asheerrizvi avatar Aug 11 '22 07:08 asheerrizvi

Maybe @asheerrizvi you good to go ahead with this issue. Seems like @Connor-McMillin is not able to work on this anymore. Thanks both ✌️

thisismattia avatar Aug 12 '22 07:08 thisismattia

Have created a PR for this: https://github.com/ONEARMY/community-platform/pull/1891

asheerrizvi avatar Aug 14 '22 15:08 asheerrizvi

@thisismattia yea that's the tricky part. The code uses a library to highlight links and I am not able to set the hover styles through that library. Have added a comment on the PR. Can you help me tag relevant people there so that I can have some help? 😅

asheerrizvi avatar Aug 15 '22 07:08 asheerrizvi

I see. Maybe @thisislawatts or @chrismclarke ? Or anyone else @davehakkens ?

thisismattia avatar Aug 15 '22 07:08 thisismattia

Never mind guys, was able to work out a solution.

asheerrizvi avatar Aug 15 '22 11:08 asheerrizvi

:tada: This issue has been resolved in version 1.20.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Aug 17 '22 05:08 onearmy-bot