suricata icon indicating copy to clipboard operation
suricata copied to clipboard

stats: Log packets/bytes per second in stats - V2

Open I3run0 opened this issue 1 year ago • 2 comments

This commit aims to add packets/bytes per second to Suricata's statistics log. To achieve this, a new type of qualifier was created and two new fields were added to the StatsRecord struct.

Link to redmine ticket: 6410

Previous PR: #9711

Suricata-verify tests: https://github.com/OISF/suricata-verify/pull/1453

Describe changes:

  • Fix StatsRegisterTmdCounter function description
  • Add tests to Suricata-verify

SV_BRANCH=https://github.com/OISF/suricata-verify/pull/1453

I3run0 avatar Nov 04 '23 16:11 I3run0

Codecov Report

Merging #9742 (13b3bcd) into master (c8a7204) will decrease coverage by 0.13%. Report is 3 commits behind head on master. The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9742      +/-   ##
==========================================
- Coverage   82.56%   82.43%   -0.13%     
==========================================
  Files         968      968              
  Lines      273827   273848      +21     
==========================================
- Hits       226074   225745     -329     
- Misses      47753    48103     +350     
Flag Coverage Δ
fuzzcorpus 64.44% <40.90%> (-0.42%) :arrow_down:
suricata-verify 61.00% <100.00%> (+0.03%) :arrow_up:
unittests 62.93% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Nov 05 '23 14:11 codecov[bot]

Updated PR description to refer to SV PR in format recognized by our CI checks, and re-triggered CI build runs.

jufajardini avatar Nov 13 '23 11:11 jufajardini

Closing as stale and changes requested

catenacyber avatar Apr 12 '24 12:04 catenacyber