suricata icon indicating copy to clipboard operation
suricata copied to clipboard

test: do not output non ascii character

Open catenacyber opened this issue 1 year ago • 3 comments

Link to redmine ticket: None

Describe changes:

  • Fix CI by not having S-V hang indefinitely because of a non-ascii character in stderr

Replaces #7868 by printing the right full content, not partially escaped ie contentstr instead of str

suricata-verify-pr: 939

catenacyber avatar Sep 15 '22 19:09 catenacyber

Information:

ERROR: QA failed on tlpw1_files_sha256.

ERROR: QA failed on ips_afp_drop_chk.

field baseline test %
tlpw1_stats_chk
.app_layer.error.http.parser 64 47 73.44%
tlpr1_stats_chk
.app_layer.error.http.parser 1548 1103 71.25%
ips_afp_stats_chk
.capture.kernel_drops 0 1130744 -
.flow.end.state.new 10800 15475 143.29%
.flow.end.tcp_state.syn_sent 0 1873 -
.flow.end.tcp_state.syn_recv 0 414 -
.flow.end.tcp_state.fin_wait1 0 343 -
.flow.end.tcp_state.fin_wait2 0 272 -
.flow.end.tcp_state.time_wait 0 238 -
.flow.end.tcp_state.last_ack 0 252 -
.flow.end.tcp_state.close_wait 0 563 -
.flow.end.tcp_liberal 108000 128729 119.19%
.tcp.reassembly_gap 108000 183198 169.63%
.tcp.overlap 0 54 -
.app_layer.error.http.parser 0 113 -
.app_layer.error.ftp.gap 0 145 -
.app_layer.error.smtp.gap 0 810 -
.app_layer.error.tls.gap 0 13796 -
.app_layer.error.ssh.gap 0 2 -
.app_layer.error.dcerpc_tcp.parser 0 571 -
.ftp.memuse 0 2582 -
generic_stats_chk
.capture.kernel_drops 0 110168 -
.flow.end.tcp_state.syn_sent 0 225 -
.flow.end.tcp_state.syn_recv 0 4 -
.flow.end.tcp_state.fin_wait1 0 30 -
.flow.end.tcp_state.fin_wait2 0 5 -
.flow.end.tcp_state.time_wait 0 10 -
.flow.end.tcp_state.last_ack 0 13 -
.flow.end.tcp_state.close_wait 0 44 -
.tcp.reassembly_gap 80952 95996 118.58%
.tcp.overlap 0 2 -
.app_layer.error.http.parser 0 19 -
.app_layer.error.ftp.gap 0 4 -
.app_layer.error.smtp.gap 0 30 -
.app_layer.error.dcerpc_tcp.parser 0 11 -
.ftp.memuse 0 239 -

Pipeline 9223

suricata-qa avatar Sep 15 '22 21:09 suricata-qa

Codecov Report

Merging #7871 (b5cf49f) into master (fe91506) will increase coverage by 0.12%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7871      +/-   ##
==========================================
+ Coverage   75.99%   76.11%   +0.12%     
==========================================
  Files         665      666       +1     
  Lines      185963   185998      +35     
==========================================
+ Hits       141327   141577     +250     
+ Misses      44636    44421     -215     
Flag Coverage Δ
fuzzcorpus 60.84% <100.00%> (-0.02%) :arrow_down:
suricata-verify 52.76% <100.00%> (+0.25%) :arrow_up:
unittests 60.69% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 15 '22 22:09 codecov[bot]

Information:

ERROR: QA failed on SURI_TLPW1_files_sha256.

field baseline test %
SURI_TLPW1_stats_chk
.app_layer.error.http.parser 64 47 73.44%

Pipeline 9232

suricata-qa avatar Sep 16 '22 15:09 suricata-qa

Replaced by https://github.com/OISF/suricata/pull/7917

catenacyber avatar Sep 23 '22 12:09 catenacyber