suricata
suricata copied to clipboard
detect/content: Consider distance in validation
Continuation of #7845
This commit modifies the validation callback to include the distance during validation.
Values of distance that cause the right edge to be exceeded are considered an error and the signature will be rejected.
Describe changes:
- fixups
Updates:
- Formatting fixup
suricata-verify-pr: 716 #suricata-verify-repo: #suricata-verify-branch: #suricata-update-pr: #suricata-update-repo: #suricata-update-branch: #libhtp-pr: #libhtp-repo: #libhtp-branch:
ERROR: ERROR: Invalid Signature config error in tlpr1_asan_cfg QA test
ERROR: QA failed on tlpr1_asan_cfg.
Pipeline 9115
Codecov Report
Merging #7846 (13ba186) into master (fe91506) will decrease coverage by
0.15%
. The diff coverage is92.42%
.
@@ Coverage Diff @@
## master #7846 +/- ##
==========================================
- Coverage 75.99% 75.84% -0.16%
==========================================
Files 665 665
Lines 185963 186015 +52
==========================================
- Hits 141327 141074 -253
- Misses 44636 44941 +305
Flag | Coverage Δ | |
---|---|---|
fuzzcorpus | 60.38% <80.64%> (-0.47%) |
:arrow_down: |
suricata-verify | 52.54% <82.45%> (+0.03%) |
:arrow_up: |
unittests | 60.70% <89.28%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Our QAlab test fails to parse a set of ETPRO rules. Can you review them and possibly work with @jmtaylor90 to see if they need to be updated?
Continued in #7932