suricata icon indicating copy to clipboard operation
suricata copied to clipboard

ftp: adds a config option ftp-hash for autofp-scheduler

Open catenacyber opened this issue 1 year ago • 2 comments

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5205

Describe changes:

  • Adds an option ftp-hash for autofp-scheduler : like hash except for FTP-ish flows

No S-V test as this is about a concurrency issue...

Modifies #7353 with documentation reworded

catenacyber avatar Aug 25 '22 14:08 catenacyber

Codecov Report

Merging #7769 (3dea6bf) into master (9353b07) will increase coverage by 0.05%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7769      +/-   ##
==========================================
+ Coverage   75.98%   76.04%   +0.05%     
==========================================
  Files         661      661              
  Lines      185764   185829      +65     
==========================================
+ Hits       141152   141311     +159     
+ Misses      44612    44518      -94     
Flag Coverage Δ
fuzzcorpus 60.92% <0.00%> (+0.09%) :arrow_up:
suricata-verify 52.51% <0.00%> (-0.01%) :arrow_down:
unittests 60.69% <0.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 25 '22 15:08 codecov[bot]

WARNING:

field test baseline %
tlpw2_single_stats_chk
.flow.spare 1950106 1835514 106.24%
tlpw2_autofp_stats_chk
.flow.spare 1961944 1812994 108.22%
.flow.memuse 518281728 550537728 94.14%
tlpw1_stats_chk
.tcp.rst 126081 105279 119.76%
tlpr1_stats_chk
.flow.memuse 579626688 845888448 68.52%
.http.memuse 16440 49320 33.33%
ips_afp_stats_chk
.flow.end.state.new 21669 10800 200.64%
.flow.end.tcp_liberal 145239 108000 134.48%
.flow.memuse 870105408 1081197888 80.48%
.tcp.reassembly_gap 268359 108000 248.48%
generic_stats_chk
.capture.kernel_drops 216790 5654519 3.83%
.flow.end.state.new 7565 14867 50.88%
.flow.end.tcp_state.syn_sent 421 183 230.05%
.flow.end.tcp_state.syn_recv 3 52 5.77%
.flow.end.tcp_state.established 54867 61527 89.18%
.flow.end.tcp_liberal 100681 90436 111.33%
.flow.memuse 760807808 709384128 107.25%
.tcp.segment_memcap_drop 0 11729 0.0%
.tcp.reassembly_gap 131383 114099 115.15%
.tcp.insert_data_normal_fail 0 11358 0.0%
.app_layer.error.http.parser 77 55 140.0%
.app_layer.error.smtp.gap 112 61 183.61%
.app_layer.error.tls.gap 71394 60833 117.36%

Pipeline 8821 WARNING: THERE IS A KNOWN BAD BASELINE WITH PACKET DROPS. bE MINDFUL OF ANY RESULTS.

suricata-qa avatar Aug 27 '22 06:08 suricata-qa