suricata icon indicating copy to clipboard operation
suricata copied to clipboard

Fix retvals for DetectTargetParse

Open jsoref opened this issue 1 year ago • 0 comments

Make sure these boxes are signed before submitting your Pull Request -- thank you.

  • [x] I have read the contributing guide lines at https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Contributing
  • [x] I have signed the Open Information Security Foundation contribution agreement at https://suricata.io/about/contribution-agreement/
  • [ ] I have updated the user guide (in doc/userguide/) to reflect the changes made (if applicable)

Link to redmine ticket:

Describe changes:

  • Fixing docs for DetectTargetParse

#suricata-verify-pr: #suricata-verify-repo: #suricata-verify-branch: #suricata-update-pr: #suricata-update-repo: #suricata-update-branch: #libhtp-pr: #libhtp-repo: #libhtp-branch:

jsoref avatar Aug 09 '22 13:08 jsoref

Thanks for the contribution.

In https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Code_Submission_Quality_Criteria we list commit message hints, including the main commit message be something like have a prefix and subsystem, e.g., "detect: function header return value clarification"

jlucovsky avatar Aug 10 '22 14:08 jlucovsky

Merged in #7839, thanks!

victorjulien avatar Sep 09 '22 08:09 victorjulien