suricata icon indicating copy to clipboard operation
suricata copied to clipboard

Http2 noalloc header compare 5454 v4

Open catenacyber opened this issue 1 year ago • 2 comments

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5454

Describe changes:

  • http2: remove to_vec in comparisons (no need to alloc)

Replaces #7685 with better style from Jason

catenacyber avatar Aug 03 '22 16:08 catenacyber

Codecov Report

Merging #7692 (074491f) into master (f3d3274) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7692      +/-   ##
==========================================
- Coverage   75.88%   75.87%   -0.02%     
==========================================
  Files         659      659              
  Lines      185668   185668              
==========================================
- Hits       140893   140872      -21     
- Misses      44775    44796      +21     
Flag Coverage Δ
fuzzcorpus 60.59% <ø> (ø)
suricata-verify 52.56% <ø> (-0.03%) :arrow_down:
unittests 60.71% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 03 '22 17:08 codecov[bot]

Information: QA ran without warnings.

Pipeline 8482

suricata-qa avatar Aug 03 '22 20:08 suricata-qa

Merged in #7713, thanks!

victorjulien avatar Aug 10 '22 08:08 victorjulien