suricata icon indicating copy to clipboard operation
suricata copied to clipboard

smb: adds fingerprint keyword

Open catenacyber opened this issue 1 year ago • 5 comments

Link to redmine ticket: TODO

Describe changes:

  • smb: adds fingerprint keyword, Kind of like TLS ja3 or hassh, for SMB

suricata-verify-pr: 844 https://github.com/OISF/suricata-verify/pull/844

Modifies #7499 with comments taken into account

catenacyber avatar Jul 06 '22 07:07 catenacyber

Codecov Report

Merging #7613 (62fcaa8) into master (a2f857e) will decrease coverage by 0.02%. The diff coverage is 92.64%.

@@            Coverage Diff             @@
##           master    #7613      +/-   ##
==========================================
- Coverage   75.73%   75.71%   -0.03%     
==========================================
  Files         659      661       +2     
  Lines      185740   185806      +66     
==========================================
+ Hits       140669   140680      +11     
- Misses      45071    45126      +55     
Flag Coverage Δ
fuzzcorpus 59.83% <25.00%> (-0.02%) :arrow_down:
suricata-verify 52.37% <80.85%> (-0.06%) :arrow_down:
unittests 60.71% <83.07%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jul 06 '22 08:07 codecov[bot]

Information: QA ran without warnings.

Pipeline 8127

suricata-qa avatar Jul 06 '22 12:07 suricata-qa

Is this hash your own invention or implementation of some kind of standard like ja3/ja3s are?

victorjulien avatar Aug 25 '22 13:08 victorjulien

Idea comes from https://github.com/micrictor/smbfp

catenacyber avatar Aug 25 '22 13:08 catenacyber

Idea comes from https://github.com/micrictor/smbfp

Thanks. Wonder if we should reach out to see if we can standardize/formalize things a bit. I worry about incompatibilities between implementations, where the strength would be if things are compatible (like with ja3 but also something like community id)

victorjulien avatar Aug 25 '22 15:08 victorjulien

Information: QA ran without warnings.

Pipeline 8127

suricata-qa avatar Oct 12 '22 07:10 suricata-qa

Information: QA ran without warnings.

Pipeline 8127

suricata-qa avatar Jan 24 '23 21:01 suricata-qa