suricata icon indicating copy to clipboard operation
suricata copied to clipboard

Smb work sn v1.1

Open regit opened this issue 2 years ago • 4 comments

Replace #7583

  • [x] I have read the contributing guide lines at https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Contributing
  • [x] I have signed the Open Information Security Foundation contribution agreement at https://suricata.io/about/contribution-agreement/
  • [x] I have updated the user guide (in doc/userguide/) to reflect the changes made (if applicable)

Link to redmine ticket:

Describe changes:

  • Move smb status to separate file
  • Don't set alias to keywords

suricata-verify-pr: 862

regit avatar Jun 29 '22 10:06 regit

ERROR:

ERROR: QA failed on ips_afp_drop_chk.

Pipeline 8021

suricata-qa avatar Jun 29 '22 13:06 suricata-qa

The commit message about updating the smb.rs with the status codes is no longer accurate now it adds things to a separate new file. Also typo definitiion

victorjulien avatar Jun 29 '22 18:06 victorjulien

Codecov Report

Merging #7585 (4838fcf) into master (a898409) will decrease coverage by 0.03%. The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #7585      +/-   ##
==========================================
- Coverage   75.80%   75.76%   -0.04%     
==========================================
  Files         658      659       +1     
  Lines      186526   186580      +54     
==========================================
- Hits       141399   141366      -33     
- Misses      45127    45214      +87     
Flag Coverage Δ
fuzzcorpus 59.83% <36.00%> (-0.13%) :arrow_down:
suricata-verify 52.42% <88.88%> (+<0.01%) :arrow_up:
unittests 60.71% <36.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jun 29 '22 18:06 codecov[bot]

@regit I think this need some small adjustments before it can go in

victorjulien avatar Aug 25 '22 13:08 victorjulien