suricata icon indicating copy to clipboard operation
suricata copied to clipboard

nfs4: fix write record handling

Open catenacyber opened this issue 2 years ago • 3 comments

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5280#change-23168

Describe changes:

  • nfs4: fix write record handling

See also commit 4418fc1b02f47533439fe00789d9c850a24271b2

For what I understand, with NFS4 (instead of NFS3), we always have complete data with these compound records PDU...

And I also understand that with a WRITEv4 we cannot know if there are more data to be written afterwards...

Thoughts ?

catenacyber avatar Jun 17 '22 09:06 catenacyber

WARNING:

field test baseline %
build_asan

Pipeline 7887

suricata-qa avatar Jun 17 '22 09:06 suricata-qa

Codecov Report

Merging #7555 (aa3a673) into master (a898409) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7555      +/-   ##
==========================================
- Coverage   75.80%   75.79%   -0.02%     
==========================================
  Files         658      658              
  Lines      186526   186526              
==========================================
- Hits       141399   141369      -30     
- Misses      45127    45157      +30     
Flag Coverage Δ
fuzzcorpus 59.95% <ø> (ø)
suricata-verify 52.38% <ø> (-0.05%) :arrow_down:
unittests 60.71% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jun 17 '22 10:06 codecov[bot]

Information: QA ran without warnings.

Pipeline 7888

suricata-qa avatar Jun 17 '22 12:06 suricata-qa

Merged in #7839, thanks!

victorjulien avatar Sep 09 '22 08:09 victorjulien