suricata icon indicating copy to clipboard operation
suricata copied to clipboard

fuzz: remove check about max transactions

Open catenacyber opened this issue 2 years ago • 3 comments

Link to redmine ticket: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=44798 and other

Describe changes:

  • removes fuzzer's check about too many transactions

HTTP1 and other can indeed pipeline many transactions. The protocols for which it caused a timeout now have their limit. I do not think this check is relevant... Ideas ?

catenacyber avatar Jun 16 '22 09:06 catenacyber

Codecov Report

Merging #7550 (443353a) into master (7ced8de) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7550      +/-   ##
==========================================
- Coverage   75.80%   75.78%   -0.02%     
==========================================
  Files         658      658              
  Lines      186527   186527              
==========================================
- Hits       141400   141367      -33     
- Misses      45127    45160      +33     
Flag Coverage Δ
fuzzcorpus 59.95% <ø> (-0.01%) :arrow_down:
suricata-verify 52.38% <ø> (-0.04%) :arrow_down:
unittests 60.72% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jun 16 '22 09:06 codecov[bot]

Information: QA ran without warnings.

Pipeline 7863

suricata-qa avatar Jun 16 '22 11:06 suricata-qa

Information: QA ran without warnings.

Pipeline 7881

suricata-qa avatar Jun 17 '22 02:06 suricata-qa

Replaced by https://github.com/OISF/suricata/pull/7755

catenacyber avatar Aug 24 '22 07:08 catenacyber