suricata icon indicating copy to clipboard operation
suricata copied to clipboard

smb: do not use tree id to match create request and response

Open catenacyber opened this issue 2 years ago • 2 comments

Link to redmine ticket: TODO Maybe related to https://redmine.openinfosecfoundation.org/issues/5332

Describe changes:

  • smb: do not use tree id to match create request and response to get SMB2 async response to work

suricata-verify-pr: 843

Follows #7498 with only second commit as https://github.com/OISF/suricata/pull/7503 got merged

catenacyber avatar Jun 14 '22 08:06 catenacyber

Codecov Report

Merging #7536 (05b13c0) into master (7ced8de) will decrease coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7536      +/-   ##
==========================================
- Coverage   75.80%   75.75%   -0.05%     
==========================================
  Files         658      658              
  Lines      186527   186523       -4     
==========================================
- Hits       141400   141309      -91     
- Misses      45127    45214      +87     
Flag Coverage Δ
fuzzcorpus 59.95% <ø> (ø)
suricata-verify 52.31% <ø> (-0.11%) :arrow_down:
unittests 60.71% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jun 14 '22 08:06 codecov[bot]

ERROR:

ERROR: QA failed on smb_files_sha256.

ERROR: QA failed on tlpw1_files_sha256.

Pipeline 7820

suricata-qa avatar Jun 14 '22 11:06 suricata-qa

Replaced by https://github.com/OISF/suricata/pull/7744

catenacyber avatar Aug 22 '22 15:08 catenacyber