detect/alert: don't lose 'drop' alert - v2

[jufajardini]

Previous PR: #7469

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5180

Describe changes:

• Use a more descriptive name for the flag that indicates the alert queue reallocation failure
• make PacketAlertSet more human-error proof
• make PacketAlertFinalize more compact

Still as draft due to the Feat 5319 commits

suricata-verify-pr: 842 https://github.com/OISF/suricata-verify/pull/842

[codecov[bot]]

Codecov Report

Merging #7476 (f896a44) into master (42a661f) will increase coverage by 0.00%. The diff coverage is 88.73%.

@@           Coverage Diff           @@
##           master    #7476   +/-   ##
=======================================
  Coverage   75.75%   75.75%           
=======================================
  Files         655      655           
  Lines      188393   188429   +36     
=======================================
+ Hits       142717   142745   +28     
- Misses      45676    45684    +8     

Flag	Coverage Δ
fuzzcorpus	60.09% <73.23%> (+<0.01%)	:arrow_up:
suricata-verify	52.25% <92.18%> (+<0.01%)	:arrow_up:
unittests	60.89% <65.57%> (-0.01%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

[suricata-qa]

ERROR:

ERROR: QA failed on tlpw1_files_sha256.

ERROR: QA failed on ips_afp_drop_chk.

Pipeline 7685

[suricata-qa]

ERROR:

ERROR: QA failed on tlpw1_files_sha256.

ERROR: QA failed on ips_afp_drop_chk.

Pipeline 7685

[jufajardini]

Replaced by https://github.com/OISF/suricata/pull/7969