suricata icon indicating copy to clipboard operation
suricata copied to clipboard

Http uri spaces 2881 v10

Open catenacyber opened this issue 2 years ago • 8 comments

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/2881

Describe changes:

  • configures libhtp to allow spaces in URIs

Modifies #7352 with rebase to get CI green

suricata-verify-pr: 837

https://github.com/OISF/suricata-verify/pull/837

catenacyber avatar May 31 '22 08:05 catenacyber

Codecov Report

Merging #7443 (1bde6da) into master (43d28f2) will decrease coverage by 0.03%. The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master    #7443      +/-   ##
==========================================
- Coverage   75.88%   75.84%   -0.04%     
==========================================
  Files         657      657              
  Lines      189473   189490      +17     
==========================================
- Hits       143775   143721      -54     
- Misses      45698    45769      +71     
Flag Coverage Δ
fuzzcorpus 60.43% <78.57%> (-0.17%) :arrow_down:
suricata-verify 52.07% <71.42%> (+0.09%) :arrow_up:
unittests 60.89% <15.38%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar May 31 '22 12:05 codecov[bot]

ERROR: ERROR: Invalid Signature config error in tlpr1_asan_cfg QA test

ERROR: QA failed on tlpr1_asan_cfg.

Pipeline 7669

suricata-qa avatar Jun 03 '22 06:06 suricata-qa

@ct0br0 @pevma I guess QA lab needs to update ET signatures again cf https://github.com/OISF/suricata-verify/pull/836

catenacyber avatar Jun 03 '22 08:06 catenacyber

ERROR: ERROR: Invalid Signature config error in tlpr1_asan_cfg QA test

ERROR: QA failed on tlpr1_asan_cfg.

Pipeline 7669 WARNING: THERE IS A KNOWN BAD BASELINE WITH PACKET DROPS. BE MINDFUL OF ANY RESULTS.

suricata-qa avatar Aug 31 '22 20:08 suricata-qa

Been having issues with notifications. Just saw this, will re-run as it hasn't changed and that pipe is old.

ct0br0 avatar Aug 31 '22 20:08 ct0br0

ERROR: ERROR: Invalid Signature config error in tlpr1_asan_cfg QA test

ERROR: QA failed on tlpr1_asan_cfg.

Pipeline 9101

suricata-qa avatar Sep 10 '22 04:09 suricata-qa

Our current version and the latest version of this SID are the same. Parsing issue must be on our side.

ct0br0 avatar Sep 12 '22 12:09 ct0br0

Waiting for a good moment to merge this as it requires a QAlab rebaseline.

victorjulien avatar Sep 19 '22 14:09 victorjulien

Replaced by https://github.com/OISF/suricata/pull/7915

catenacyber avatar Sep 23 '22 11:09 catenacyber