suricata icon indicating copy to clipboard operation
suricata copied to clipboard

ftp: adds a config option ftp-hash for autofp-scheduler

Open catenacyber opened this issue 2 years ago • 2 comments

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5205

Describe changes:

  • Adds an option ftp-hash for autofp-scheduler : like hash except for FTP-ish flows

No S-V test as this is about a concurrency issue...

Modifies #7319 with review taken into account

catenacyber avatar May 02 '22 11:05 catenacyber

Codecov Report

Merging #7353 (2b74b5e) into master (323fe1c) will decrease coverage by 0.06%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7353      +/-   ##
==========================================
- Coverage   75.84%   75.78%   -0.07%     
==========================================
  Files         656      656              
  Lines      190093   190154      +61     
==========================================
- Hits       144172   144099      -73     
- Misses      45921    46055     +134     
Flag Coverage Δ
fuzzcorpus 60.39% <0.00%> (-0.08%) :arrow_down:
suricata-verify 51.66% <0.00%> (-0.09%) :arrow_down:
unittests 61.01% <0.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar May 02 '22 12:05 codecov[bot]

ERROR:

ERROR: QA failed on tlpw1_files_sha256.

field test baseline %
tlpr1_stats_chk
.app_layer.error.ftp-data.parser 0 395 0.0%

Pipeline 7357

suricata-qa avatar May 08 '22 02:05 suricata-qa

ERROR:

ERROR: QA failed on tlpw1_files_sha256.

field test baseline %
tlpr1_stats_chk
.app_layer.error.ftp-data.parser 0 395 0.0%

Pipeline 7357 WARNING: THERE IS A KNOWN BAD BASELINE WITH PACKET DROPS. bE MINDFUL OF ANY RESULTS.

suricata-qa avatar Aug 24 '22 14:08 suricata-qa

Replaces by https://github.com/OISF/suricata/pull/7769

catenacyber avatar Aug 25 '22 14:08 catenacyber