suricata icon indicating copy to clipboard operation
suricata copied to clipboard

detect/content: Consider distance in validation

Open jlucovsky opened this issue 2 years ago • 4 comments

Continuation of #6954

This commit modifies the validation callback to include the distance during validation.

Values of distance that cause the right edge to be exceeded are considered an error and the signature will be rejected.

Link to redmine ticket: 2982

Describe changes:

  • fixups

Updates:

  • clang-format

suricata-verify-pr: 716 #suricata-verify-repo: #suricata-verify-branch: #suricata-update-pr: #suricata-update-repo: #suricata-update-branch: #libhtp-pr: #libhtp-repo: #libhtp-branch:

jlucovsky avatar Feb 09 '22 13:02 jlucovsky

Codecov Report

Merging #6960 (7867f3f) into master (97ef60c) will decrease coverage by 0.06%. The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master    #6960      +/-   ##
==========================================
- Coverage   77.74%   77.67%   -0.07%     
==========================================
  Files         628      628              
  Lines      185648   185706      +58     
==========================================
- Hits       144332   144252      -80     
- Misses      41316    41454     +138     
Flag Coverage Δ
fuzzcorpus 58.24% <81.66%> (-0.06%) :arrow_down:
suricata-verify 54.41% <83.63%> (-0.02%) :arrow_down:
unittests 63.04% <90.74%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Feb 09 '22 14:02 codecov[bot]

ERROR: ERROR: Invalid Signature config error in tlpr1_asan_cfg QA test

ERROR: QA failed on tlpr1_asan_cfg.

Pipeline 6405

suricata-qa avatar Feb 27 '22 05:02 suricata-qa

Note: please make sure all tickets in the commits are mentioned in the PR:

  • https://redmine.openinfosecfoundation.org/issues/3682

Please update PR body and remove the 'needs ticket' label when done.

suricata-qa avatar Apr 26 '22 15:04 suricata-qa

ERROR: ERROR: Invalid Signature config error in tlpr1_asan_cfg QA test

ERROR: QA failed on tlpr1_asan_cfg.

Pipeline 6405

suricata-qa avatar Jun 17 '22 04:06 suricata-qa

Is there a new PR @jlucovsky ? will there be ? Is this work given up ? (why did you close this ?)

catenacyber avatar Aug 22 '22 12:08 catenacyber