suricata
suricata copied to clipboard
detect/content: Consider distance in validation
Continuation of #6954
This commit modifies the validation callback to include the distance during validation.
Values of distance that cause the right edge to be exceeded are considered an error and the signature will be rejected.
Describe changes:
- fixups
Updates:
- clang-format
suricata-verify-pr: 716 #suricata-verify-repo: #suricata-verify-branch: #suricata-update-pr: #suricata-update-repo: #suricata-update-branch: #libhtp-pr: #libhtp-repo: #libhtp-branch:
Codecov Report
Merging #6960 (7867f3f) into master (97ef60c) will decrease coverage by
0.06%
. The diff coverage is93.75%
.
@@ Coverage Diff @@
## master #6960 +/- ##
==========================================
- Coverage 77.74% 77.67% -0.07%
==========================================
Files 628 628
Lines 185648 185706 +58
==========================================
- Hits 144332 144252 -80
- Misses 41316 41454 +138
Flag | Coverage Δ | |
---|---|---|
fuzzcorpus | 58.24% <81.66%> (-0.06%) |
:arrow_down: |
suricata-verify | 54.41% <83.63%> (-0.02%) |
:arrow_down: |
unittests | 63.04% <90.74%> (-0.05%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
ERROR: ERROR: Invalid Signature config error in tlpr1_asan_cfg QA test
ERROR: QA failed on tlpr1_asan_cfg.
Pipeline 6405
Note: please make sure all tickets in the commits are mentioned in the PR:
- https://redmine.openinfosecfoundation.org/issues/3682
Please update PR body and remove the 'needs ticket' label when done.
ERROR: ERROR: Invalid Signature config error in tlpr1_asan_cfg QA test
ERROR: QA failed on tlpr1_asan_cfg.
Pipeline 6405
Is there a new PR @jlucovsky ? will there be ? Is this work given up ? (why did you close this ?)