suricata icon indicating copy to clipboard operation
suricata copied to clipboard

Correct LB + Netmap YAML usage

Open retr0h opened this issue 3 years ago • 3 comments

Make sure these boxes are signed before submitting your Pull Request -- thank you.

  • [x] I have read the contributing guide lines at https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Contributing
  • [x] I have signed the Open Information Security Foundation contribution agreement at https://suricata-ids.org/about/contribution-agreement/
  • [x] I have updated the user guide (in doc/userguide/) to reflect the changes made (if applicable)

Describe changes:

  • Corrected the example YAML configuration when using Netmap and LB.

#suricata-verify-pr: #suricata-verify-repo: #suricata-verify-branch: #suricata-update-pr: #suricata-update-repo: #suricata-update-branch: #libhtp-pr: #libhtp-repo: #libhtp-branch:

retr0h avatar Mar 10 '21 20:03 retr0h

Codecov Report

Merging #5970 (a77b623) into master (55a0e29) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5970   +/-   ##
=======================================
  Coverage   76.79%   76.79%           
=======================================
  Files         612      612           
  Lines      188368   188368           
=======================================
+ Hits       144656   144662    +6     
+ Misses      43712    43706    -6     
Flag Coverage Δ
fuzzcorpus 52.67% <ø> (+<0.01%) :arrow_up:
suricata-verify 50.13% <ø> (+0.04%) :arrow_up:
unittests 63.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Mar 10 '21 21:03 codecov[bot]

was this always wrong or is this a change within netmap/lb that happend?

norg avatar Mar 29 '21 20:03 norg

was this always wrong or is this a change within netmap/lb that happend?

I think it was always wrong @norg

retr0h avatar Mar 30 '21 16:03 retr0h

Merged in #8815, thanks!

victorjulien avatar May 05 '23 15:05 victorjulien