suricata icon indicating copy to clipboard operation
suricata copied to clipboard

draft: cleanup low level loggers for plugin/library use - v4

Open jasonish opened this issue 1 year ago • 3 comments

Previous PR: https://github.com/OISF/suricata/pull/9493 Ticket: https://redmine.openinfosecfoundation.org/issues/7227

Changes from last PR:

  • Cleanup and document packet logging
  • Devguide entry

jasonish avatar Aug 27 '24 23:08 jasonish

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.62%. Comparing base (304271e) to head (3c6d20f). Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11666   +/-   ##
=======================================
  Coverage   82.61%   82.62%           
=======================================
  Files         919      919           
  Lines      248997   248941   -56     
=======================================
- Hits       205717   205689   -28     
+ Misses      43280    43252   -28     
Flag Coverage Δ
fuzzcorpus 60.88% <98.01%> (+<0.01%) :arrow_up:
livemode 18.64% <97.02%> (-0.03%) :arrow_down:
pcap 44.16% <97.02%> (+0.01%) :arrow_up:
suricata-verify 61.87% <100.00%> (-0.03%) :arrow_down:
unittests 59.01% <79.20%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 27 '24 23:08 codecov[bot]

Information: QA ran without warnings.

Pipeline 22272

suricata-qa avatar Aug 28 '24 04:08 suricata-qa

Information: QA ran without warnings.

Pipeline 22273

suricata-qa avatar Aug 28 '24 06:08 suricata-qa

Information: QA ran without warnings.

Pipeline 22281

suricata-qa avatar Aug 28 '24 22:08 suricata-qa

Information: QA ran without warnings.

Pipeline 22292

suricata-qa avatar Aug 30 '24 06:08 suricata-qa

Replaced by https://github.com/OISF/suricata/pull/11686.

jasonish avatar Aug 30 '24 20:08 jasonish