suricata icon indicating copy to clipboard operation
suricata copied to clipboard

dpdk: add initial unittests for DPDK codebase v3

Open lukashino opened this issue 7 months ago • 3 comments

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6927 Follow-up of: #10838

Describe changes: v3

  • comments from Philippe
  • I left TAILQ_INIT in the finalize/cleanup functions - all elements of the arrays are cleaned but not the base pointer of the array itself. TAILQ_* functions don't offer reset function but TAILQ_INIT provides the desired outcome
  • moved guards around - per Philippe's suggestions

v2

  • added a FatalError check on the number of LiveDevices
  • changed #if HAVE_DPDK to #if defined(HAVE_DPDK) && defined(UNITTESTS)
  • enabled unit tests in the Github workflow runs on Ubuntu and Fedora tasks

v1

  • function-guarded variable
  • fix the CPU exclude logic
  • add DPDK unit tests

lukashino avatar Jul 14 '24 21:07 lukashino