suricata icon indicating copy to clipboard operation
suricata copied to clipboard

detect/dataset: skip adding localstatedir if fullpath is provided

Open norg opened this issue 3 weeks ago • 8 comments

When the option to set a full path is enabled and a full path is provided, skip adding the prefix (based on localstatedir) to the directory since it would be unexpected and unwanted by a user.

Ticket: 7083

Make sure these boxes are signed before submitting your Pull Request -- thank you.

  • [x] I have read the contributing guide lines at https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
  • [x] I have signed the Open Information Security Foundation contribution agreement at https://suricata.io/about/contribution-agreement/ (note: this is only required once)
  • [x] I have updated the user guide (in doc/userguide/) to reflect the changes made (if applicable)
  • [x] I have created a ticket at https://redmine.openinfosecfoundation.org/projects/suricata/issues (if applicable)

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7083

Describe changes:

  • When a user enables the option to provide a full path for a dataset, the prefix (based on localstatedir) should not be added since it doesn't make much sense to add that prefix on a provided full path
  • This commit adds a check to skip the prefix addition in that case

Provide values to any of the below to override the defaults.

  • To use an LibHTP, Suricata-Verify or Suricata-Update pull request, link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO= SV_BRANCH= SU_REPO= SU_BRANCH= LIBHTP_REPO= LIBHTP_BRANCH=

norg avatar Jun 10 '24 09:06 norg