suricata
suricata copied to clipboard
LDAP protocol parser v2
Make sure these boxes are signed before submitting your Pull Request -- thank you.
- [x] I have read the contributing guide lines at https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
- [x] I have signed the Open Information Security Foundation contribution agreement at https://suricata.io/about/contribution-agreement/ (note: this is only required once)
- [x] I have updated the user guide (in doc/userguide/) to reflect the changes made (if applicable)
- [x] I have created a ticket at https://redmine.openinfosecfoundation.org/projects/suricata/issues (if applicable)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Describe changes:
- Most of the comments in the previous PR have been addressed
- All operations are implemented, except for
Abandon Requestbecause apparently is not parsed correctly (see https://github.com/rusticata/ldap-parser/issues/6) - schema.json is added
- SV tests are WIP
Codecov Report
Attention: Patch coverage is 12.69488% with 784 lines in your changes are missing coverage. Please review.
Project coverage is 80.53%. Comparing base (
fcdd7f0) to head (55a5124).
Additional details and impacted files
@@ Coverage Diff @@
## master #11087 +/- ##
===========================================
+ Coverage 64.19% 80.53% +16.33%
===========================================
Files 847 926 +79
Lines 136684 251175 +114491
===========================================
+ Hits 87750 202276 +114526
+ Misses 48934 48899 -35
| Flag | Coverage Δ | |
|---|---|---|
| fuzzcorpus | 63.88% <12.69%> (-0.32%) |
:arrow_down: |
| livemode | 19.31% <5.34%> (?) |
|
| unittests | 62.03% <5.34%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Replaced with https://github.com/OISF/suricata/pull/11163