suricata icon indicating copy to clipboard operation
suricata copied to clipboard

Threshold cache/v11

Open victorjulien opened this issue 1 year ago • 2 comments

Reimplement threshold storage and add a thread local cache, both to reduce lock contention.

https://redmine.openinfosecfoundation.org/issues/426 https://redmine.openinfosecfoundation.org/issues/6967

Replaces https://github.com/OISF/suricata/pull/11026:

  • adds config opts
  • doc for config opts
  • address review comments

Review in isolation, no relation other thresholding PRs.

victorjulien avatar May 15 '24 09:05 victorjulien

Codecov Report

Attention: Patch coverage is 87.71930% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 83.64%. Comparing base (806052d) to head (0ac580b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11077      +/-   ##
==========================================
+ Coverage   83.63%   83.64%   +0.01%     
==========================================
  Files         922      922              
  Lines      250375   250403      +28     
==========================================
+ Hits       209399   209455      +56     
+ Misses      40976    40948      -28     
Flag Coverage Δ
fuzzcorpus 64.20% <25.26%> (-0.02%) :arrow_down:
livemode 18.54% <12.63%> (+0.13%) :arrow_up:
suricata-verify 62.74% <50.00%> (-0.05%) :arrow_down:
unittests 62.35% <78.94%> (+0.09%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar May 15 '24 09:05 codecov[bot]

Information:

ERROR: QA failed on SURI_TLPR1_suri_time.

field baseline test %
SURI_TLPR1_stats_chk
.uptime 645 672 104.19%

Pipeline 20648

suricata-qa avatar May 16 '24 09:05 suricata-qa

Replaced by #11171

victorjulien avatar May 29 '24 09:05 victorjulien