suricata
suricata copied to clipboard
Rustc 178 fixes 7013 v4
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/7013
Describe changes:
- Fix build with rustc 1.78
- do not bother to free a null pointer in tests
- rust: return empty slice without using from_raw_parts fro StreamSlice
- protocol detection/probing : consistently check for NULL input (was done for half of the protocols)
#11041 with code review taken into account
- revert of temporary 14ab9aa763d44dda0f4c831047966b595f5630c1 cc @jasonish what was the purpose of this commit ?
Codecov Report
Attention: Patch coverage is 77.41935%
with 7 lines
in your changes are missing coverage. Please review.
Project coverage is 83.62%. Comparing base (
cb56752
) to head (3d2b65e
).
Additional details and impacted files
@@ Coverage Diff @@
## master #11062 +/- ##
==========================================
- Coverage 83.63% 83.62% -0.02%
==========================================
Files 922 922
Lines 250321 250342 +21
==========================================
- Hits 209349 209336 -13
- Misses 40972 41006 +34
Flag | Coverage Δ | |
---|---|---|
fuzzcorpus | 64.20% <74.19%> (-0.02%) |
:arrow_down: |
livemode | 18.41% <0.00%> (-0.01%) |
:arrow_down: |
suricata-verify | 62.73% <70.96%> (-0.03%) |
:arrow_down: |
unittests | 62.26% <6.45%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Information: QA ran without warnings.
Pipeline 20596
revert of temporary 14ab9aa cc @jasonish what was the purpose of this commit ?
To revert back to previous rustc behavior to get it my PRs to pass qa.
Merged in #11084, thanks!