suricata
suricata copied to clipboard
Convert byte_extract keyword parser to Rust
Continuation of #11017
Convert the byte_extract option parser from C to Rust.
Describe changes:
- Refactor code in rust/src/detect to support re-usability
- Implement the byte_extract parser in Rust, with unittests
- Modify the existing byte_extract module to use the Rust parser
Updates:
- Address clippy warning
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like pr/N
where N
is the
pull request number.
Alternatively, SV_BRANCH
may also be a link to an
OISF/suricata-verify pull-request.
SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=
Codecov Report
Attention: Patch coverage is 96.55963%
with 30 lines
in your changes are missing coverage. Please review.
Project coverage is 83.61%. Comparing base (
f14a4a1
) to head (1cc9eee
).
Additional details and impacted files
@@ Coverage Diff @@
## master #11018 +/- ##
==========================================
+ Coverage 80.66% 83.61% +2.94%
==========================================
Files 923 923
Lines 250204 250242 +38
==========================================
+ Hits 201833 209238 +7405
+ Misses 48371 41004 -7367
Flag | Coverage Δ | |
---|---|---|
fuzzcorpus | 64.17% <75.74%> (-0.14%) |
:arrow_down: |
livemode | 18.55% <0.00%> (+0.13%) |
:arrow_up: |
suricata-verify | 62.81% <60.39%> (?) |
|
unittests | 62.32% <96.21%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Information: QA ran without warnings.
Pipeline 20497
You can use that to take care of the nitpicks ;-p
Continued in #11308