suricata icon indicating copy to clipboard operation
suricata copied to clipboard

ARP: implement decoder and logger v7

Open glongo opened this issue 2 months ago • 1 comments

Make sure these boxes are signed before submitting your Pull Request -- thank you.

  • [x] I have read the contributing guide lines at https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
  • [x] I have signed the Open Information Security Foundation contribution agreement at https://suricata.io/about/contribution-agreement/ (note: this is only required once)
  • [x] I have updated the user guide (in doc/userguide/) to reflect the changes made (if applicable)

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6827

Describe changes:

  • Fix doc
  • Fix guard style
  • Use JSON_ADDR_LEN
  • Remove unused header file

SV_BRANCH=https://github.com/OISF/suricata-verify/pull/1807

glongo avatar May 01 '24 07:05 glongo

Codecov Report

Attention: Patch coverage is 35.23810% with 136 lines in your changes are missing coverage. Please review.

Project coverage is 82.95%. Comparing base (c53e9ac) to head (72e2b6d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11005      +/-   ##
==========================================
- Coverage   82.99%   82.95%   -0.05%     
==========================================
  Files         917      919       +2     
  Lines      248684   248888     +204     
==========================================
+ Hits       206401   206468      +67     
- Misses      42283    42420     +137     
Flag Coverage Δ
fuzzcorpus 64.17% <14.28%> (-0.08%) :arrow_down:
suricata-verify 62.65% <34.28%> (-0.02%) :arrow_down:
unittests 62.27% <2.38%> (-0.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar May 01 '24 08:05 codecov[bot]

Replaced with https://github.com/OISF/suricata/pull/11038

glongo avatar May 07 '24 17:05 glongo