suricata icon indicating copy to clipboard operation
suricata copied to clipboard

Feat/6927 add unit tests v2

Open lukashino opened this issue 10 months ago • 3 comments

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6927 Follow-up of: #10786

Describe changes: v2

  • added a FatalError check on the number of LiveDevices
  • changed #if HAVE_DPDK to #if defined(HAVE_DPDK) && defined(UNITTESTS)
  • enabled unit tests in the Github workflow runs on Ubuntu and Fedora tasks

v1

  • function-guarded variable
  • fix the CPU exclude logic
  • add DPDK unit tests

lukashino avatar Apr 14 '24 10:04 lukashino

Codecov Report

Attention: Patch coverage is 92.88136% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 82.41%. Comparing base (784ce30) to head (0c7ea10). Report is 127 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10838      +/-   ##
==========================================
- Coverage   82.83%   82.41%   -0.42%     
==========================================
  Files         913      919       +6     
  Lines      246847   248831    +1984     
==========================================
+ Hits       204474   205083     +609     
- Misses      42373    43748    +1375     
Flag Coverage Δ
fuzzcorpus 64.35% <14.28%> (+0.05%) :arrow_up:
suricata-verify 62.08% <28.57%> (-0.02%) :arrow_down:
unittests 62.07% <92.88%> (-0.26%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Apr 14 '24 11:04 codecov[bot]

Information: QA ran without warnings.

Pipeline 20058

suricata-qa avatar Apr 14 '24 13:04 suricata-qa

On the next PR, please set a descriptive title.

victorjulien avatar Jun 08 '24 05:06 victorjulien

Follow up in https://github.com/OISF/suricata/pull/11494

lukashino avatar Jul 14 '24 21:07 lukashino