Port grouping redo/v8.1

[victorjulien]

#10450 with a bunch of fixes. Groups are still not entirely what they should be.

[victorjulien]

cppcheck is a bit grumpy here:

src/util-interval-tree.c:58:1: warning: Either the condition 'tmp!=NULL' is redundant or there is possible null pointer dereference: tmp. [nullPointerRedundantCheck]
IRB_GENERATE(PI, SCIntervalNode, irb, PICompareAndUpdate);
^
src/util-interval-tree.c:58:1: note: Assuming that condition 'tmp!=NULL' is not redundant
IRB_GENERATE(PI, SCIntervalNode, irb, PICompareAndUpdate);
^
src/util-interval-tree.c:58:1: note: Null pointer dereference
IRB_GENERATE(PI, SCIntervalNode, irb, PICompareAndUpdate);
^
src/util-interval-tree.c:58:1: warning: Either the condition 'oleft!=NULL' is redundant or there is possible null pointer dereference: oleft. [nullPointerRedundantCheck]
IRB_GENERATE(PI, SCIntervalNode, irb, PICompareAndUpdate);
^
src/util-interval-tree.c:58:1: note: Assuming that condition 'oleft!=NULL' is not redundant
IRB_GENERATE(PI, SCIntervalNode, irb, PICompareAndUpdate);
^
src/util-interval-tree.c:58:1: note: Null pointer dereference
IRB_GENERATE(PI, SCIntervalNode, irb, PICompareAndUpdate);
^
src/util-interval-tree.c:58:1: warning: Either the condition 'oright!=NULL' is redundant or there is possible null pointer dereference: oright. [nullPointerRedundantCheck]
IRB_GENERATE(PI, SCIntervalNode, irb, PICompareAndUpdate);
^
src/util-interval-tree.c:58:1: note: Assuming that condition 'oright!=NULL' is not redundant
IRB_GENERATE(PI, SCIntervalNode, irb, PICompareAndUpdate);
^
src/util-interval-tree.c:58:1: note: Null pointer dereference
IRB_GENERATE(PI, SCIntervalNode, irb, PICompareAndUpdate);
^
src/util-interval-tree.c:58:1: warning: Either the condition 'left!=NULL' is redundant or there is possible null pointer dereference: left. [nullPointerRedundantCheck]
IRB_GENERATE(PI, SCIntervalNode, irb, PICompareAndUpdate);
^
src/util-interval-tree.c:58:1: note: Assuming that condition 'left!=NULL' is not redundant
IRB_GENERATE(PI, SCIntervalNode, irb, PICompareAndUpdate);
^
src/util-interval-tree.c:58:1: note: Null pointer dereference
IRB_GENERATE(PI, SCIntervalNode, irb, PICompareAndUpdate);
^

I remember fighting the other tree.h macros wrt scan-build, so perhaps we need similar logic here.

[suricata-qa]

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

field	baseline	test	%
	SURI_TLPW2_autofp_stats_chk
.uptime	101	113	111.88%

Pipeline 18594

[suricata-qa]

ERROR:

ERROR: QA failed on build_dbg.

ERROR: QA failed on ASAN_TLPR1_collect.

Pipeline 18595

[suricata-qa]

Information: QA ran without warnings.

Pipeline 18595

[suricata-qa]

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

field	baseline	test	%
	SURI_TLPW2_autofp_stats_chk
.uptime	101	111	109.9%

Pipeline 18609

[inashivb]

All comments addressed in https://github.com/OISF/suricata/pull/10511