suricata icon indicating copy to clipboard operation
suricata copied to clipboard

hugepages: run hugepage check only on DPDK runmode and on Linux v3

Open lukashino opened this issue 1 year ago • 1 comments

Follow-up of https://github.com/OISF/suricata/pull/10358

The previous implementation allowed FreeBSD to enter into the hugepage analysis. It then failed with an error message because hugepage/ NUMA node paths that are used in the codebase to retrieve info about the system are not the same as the structure in Linux.

Additionally, the messages were logged on an error level. It has been demoted to the info level because the whole hugepage analysis checkup is only for informational purposes and does not affect Suricata operation.

The hugepage analysis and the hugepage snapshots are now limited to only run in the DPDK runmode.

Changes: v3 changes:

  • remove guards
  • add a path check to determine hugepage validation
  • add OS determination
  • force-push change - adjusted the enum to follow the snake case format

Ticket: https://redmine.openinfosecfoundation.org/issues/6760 Ticket: https://redmine.openinfosecfoundation.org/issues/6762

lukashino avatar Feb 16 '24 09:02 lukashino

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 101 112 110.89%

Pipeline 18579

suricata-qa avatar Feb 16 '24 17:02 suricata-qa

#10471 has a followup

lukashino avatar Feb 20 '24 20:02 lukashino