suricata dns: add dns.rcode keyword

dns: add dns.rcode keyword - v8

Open hadiqaalamdar opened this issue 1 year ago • 1 comments

Feature #6621

[x] I have read the contributing guide lines at https://docs.suricata.io/en/latest/devguide/codebase/contributing/contribution-process.html
[x] I have signed the Open Information Security Foundation contribution agreement at https://suricata.io/about/contribution-agreement/
[x] I have updated the user guide (in doc/userguide/) to reflect the changes made (if applicable)

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6621

Previous PR: https://github.com/OISF/suricata/pull/10249

Describe changes:

made the suggested changes from the previous PR
made changes to documentation
successfully ran the following tests:
from rust dir: make check
from rust dir: cargo test
from rust dir: cargo clippy --all-features
from rust dir: rustfmt src/dns/*
from suricata dir: ./scripts/clang-format.sh check-branch
from suricata dir: ./scripts/clang-format.sh branch
from suricata dir running ./src/suricata -u showed that one unit test had failed.
from suricata dir running ./src/suricata -u -U dns showed 7 tests passed.

SV_BRANCH=https://github.com/OISF/suricata-verify/pull/1578

Feb 15 '24 13:02 hadiqaalamdar

Rebasing your S-V branch should clean up the CI errors.

Feb 15 '24 14:02 jasonish

New PR: https://github.com/OISF/suricata/pull/10458

Feb 19 '24 14:02 hadiqaalamdar