suricata icon indicating copy to clipboard operation
suricata copied to clipboard

napatech: Close streams on hard errors

Open jlucovsky opened this issue 1 year ago • 3 comments

Issue: 5172

This commit forces the current stream to be closed when a hard error occurs.

Without this commit, a hard error will force a 2nd connection the stream that raised the error.

With this commit, the stream with the hard error is closed before opening another connection to the stream.

Verified with the Python snippet in the redmine issue. 5172

Make sure these boxes are signed before submitting your Pull Request -- thank you.

  • [x] I have read the contributing guide lines at https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
  • [x] I have signed the Open Information Security Foundation contribution agreement at https://suricata.io/about/contribution-agreement/ (note: this is only required once)
  • [x] I have updated the user guide (in doc/userguide/) to reflect the changes made (if applicable)

Link to redmine ticket:

Describe changes:

  • On hard errors from NT_RxGet, the stream is closed before re-opening the stream.

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the pull request number.

Alternatively, SV_BRANCH may also be a link to an OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

jlucovsky avatar Jan 29 '24 18:01 jlucovsky

Information: QA ran without warnings.

Pipeline 17829

suricata-qa avatar Jan 29 '24 21:01 suricata-qa

@ralpheastwood can you review this? Thanks!

victorjulien avatar Jan 30 '24 05:01 victorjulien

Hi @jlucovsky @victorjulien - I have reviewed the code and it looks good to me.

ralpheastwood avatar Feb 16 '24 11:02 ralpheastwood

Merged in #10469, thanks!

victorjulien avatar Feb 21 '24 06:02 victorjulien