suricata icon indicating copy to clipboard operation
suricata copied to clipboard

Detect pass alert/v2

Open victorjulien opened this issue 1 year ago • 5 comments

This implements an alert keyword, as the opposite of the noalert keyword. It allows rules that pass-then-alert.

https://redmine.openinfosecfoundation.org/issues/5466

SV_BRANCH=https://github.com/OISF/suricata-verify/pull/1579

victorjulien avatar Jan 12 '24 13:01 victorjulien

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1dcf69b) 82.19% compared to head (0175cba) 82.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10154      +/-   ##
==========================================
- Coverage   82.19%   82.08%   -0.11%     
==========================================
  Files         974      974              
  Lines      271825   271838      +13     
==========================================
- Hits       223416   223131     -285     
- Misses      48409    48707     +298     
Flag Coverage Δ
fuzzcorpus 62.67% <73.91%> (-0.35%) :arrow_down:
suricata-verify 61.40% <91.30%> (-0.02%) :arrow_down:
unittests 62.85% <70.21%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jan 12 '24 13:01 codecov[bot]

ERROR:

ERROR: QA failed on ASAN_TLPR1_suri.

Pipeline 17490

suricata-qa avatar Jan 12 '24 14:01 suricata-qa

Information:

ERROR: QA failed on SURI_TLPW1_suri_time.

field baseline test %
SURI_TLPW1_stats_chk
.uptime 137 146 106.57%

Pipeline 17491

suricata-qa avatar Jan 12 '24 16:01 suricata-qa

Any update on this ?

catenacyber avatar Apr 30 '24 09:04 catenacyber

ERROR:

ERROR: QA failed on SURI_TLPW1_suri_time.

ERROR: QA failed on SURI_TLPW1_stats_chk.

Pipeline 17491

suricata-qa avatar May 05 '24 11:05 suricata-qa

replaced by #10157

victorjulien avatar Jun 07 '24 11:06 victorjulien