suricata-verify icon indicating copy to clipboard operation
suricata-verify copied to clipboard

Published 20 hours ago • verified publisher icon OISF

tests/transform: from_base64 test

Open jlucovsky opened this issue 1 year ago • 5 comments

from_base64 transform test

Ticket

If your pull request is related to a Suricata ticket, please provide the full URL to the ticket here so this pull request can monitor changes to the ticket status:

Redmine ticket: 6487

Updates

  • Mode specific tests

jlucovsky avatar Feb 27 '24 14:02 jlucovsky

Continued in #10512

Oops -- erroneously closed.

jlucovsky avatar Feb 27 '24 14:02 jlucovsky

Can you also add a test that depends on the mode? Ideally we'd have one per option, that would only pass with that specific "mode" setting.

victorjulien avatar Feb 27 '24 17:02 victorjulien

Additional request: add some tests that force the pattern after from_base64 to be the fast pattern.

victorjulien avatar Apr 30 '24 07:04 victorjulien

Additional request: add some tests that force the pattern after from_base64 to be the fast pattern.

Will do.

jlucovsky avatar Apr 30 '24 12:04 jlucovsky

Can you also add a test that depends on the mode? Ideally we'd have one per option, that would only pass with that specific "mode" setting.

Yes; done.

jlucovsky avatar Apr 30 '24 12:04 jlucovsky

Merged in #1937, thanks!

victorjulien avatar Jun 24 '24 07:06 victorjulien