libhtp
libhtp copied to clipboard
Http1 removetx 5921 v12
#418 with SV passing for http-sticky-server
:
do not pop out of the list when removing a tx, as the list size is used for tx count
Looks better https://github.com/OISF/suricata/actions/runs/8812620289
Looks better https://github.com/OISF/suricata/actions/runs/8812620289
So, will you merge this ?
Testing the auto-libhtp-PR pickup with this. Run should be done this afternoon ~4hr
Information: QA ran without warnings.
Pipeline 20399
Thinking giving up on this optimization, and working on libhtp-rs 🤔
Giving up on this optimization, so summing up :
- this optimization assumed that the transactions got freed in sequential order
- this assumption is wrong (2 pipelined requests, first got responses, second gets not, and so the file logger delays the cleanup pf the first tx after the second one which has no file to log)
Because of the list structure, which can be realloced, and its elements moved, we cannot keep the index where we put it somewhere to reuse it when replacing