libhtp icon indicating copy to clipboard operation
libhtp copied to clipboard

Http1 removetx 5921 v12

Open catenacyber opened this issue 10 months ago • 4 comments

#418 with SV passing for http-sticky-server : do not pop out of the list when removing a tx, as the list size is used for tx count

catenacyber avatar Apr 23 '24 21:04 catenacyber

Looks better https://github.com/OISF/suricata/actions/runs/8812620289

victorjulien avatar Apr 24 '24 08:04 victorjulien

Looks better https://github.com/OISF/suricata/actions/runs/8812620289

So, will you merge this ?

catenacyber avatar Apr 29 '24 07:04 catenacyber

Testing the auto-libhtp-PR pickup with this. Run should be done this afternoon ~4hr

ct0br0 avatar Apr 29 '24 12:04 ct0br0

Information: QA ran without warnings.

Pipeline 20399

suricata-qa avatar Apr 29 '24 15:04 suricata-qa

Thinking giving up on this optimization, and working on libhtp-rs 🤔

catenacyber avatar Jun 04 '24 20:06 catenacyber

Giving up on this optimization, so summing up :

  • this optimization assumed that the transactions got freed in sequential order
  • this assumption is wrong (2 pipelined requests, first got responses, second gets not, and so the file logger delays the cleanup pf the first tx after the second one which has no file to log)

Because of the list structure, which can be realloced, and its elements moved, we cannot keep the index where we put it somewhere to reuse it when replacing

catenacyber avatar Jun 06 '24 14:06 catenacyber