libhtp icon indicating copy to clipboard operation
libhtp copied to clipboard

HTP_AUTH_UNRECOGNIZED for Bearer tokens

Open chrislujan opened this issue 4 years ago • 6 comments

https://github.com/OISF/libhtp/blob/9cce4fb5348027fe666f21beeb829324a3afe79a/htp/htp_parsers.c#L178

This will flag the authorization header as HTP_AUTH_UNRECOGNIZED for Bearer tokens. Would it make sense to add 'bearer' as a type?

chrislujan avatar Mar 10 '21 20:03 chrislujan

I think it would make sense indeed. Do you want to propose a Pull Request about it ?

catenacyber avatar Mar 11 '21 08:03 catenacyber

yeah I can push something up quickly but this would be my first commit here so bear with me as I learn the convention.

chrislujan avatar Mar 22 '21 17:03 chrislujan

Thanks, waiting for your first PR then :-)

catenacyber avatar Mar 22 '21 19:03 catenacyber

I'm not seeing any documentation on contribution guidelines and don't have access rights to submit a branch, could you point me in the right direction?

chrislujan avatar Mar 22 '21 21:03 chrislujan

don't have access rights to submit a branch

You should fork this repository, and then create a Pull Request from your repository to this one

I'm not seeing any documentation on contribution guidelines

You can check the ones about suricata

catenacyber avatar Mar 23 '21 07:03 catenacyber

Thanks for the info! https://github.com/OISF/libhtp/pull/325

chrislujan avatar Mar 24 '21 18:03 chrislujan

Fixed by https://github.com/OISF/libhtp/pull/393

catenacyber avatar Aug 28 '23 19:08 catenacyber