Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

[Bug] When SeriesDescription is blank, Segmentation drop-down selector item height is diminished

Open fedorov opened this issue 1 month ago • 6 comments

Describe the Bug

I discovered that blank series description will result in a drop-down item that is very easy to miss. In the screenshot below, the highlighted item before "Segmentation" is actually an RTSTRUCT set.

Image

Steps to Reproduce

  1. Go to https://viewer.imaging.datacommons.cancer.gov/v3/viewer/?StudyInstanceUIDs=1.3.6.1.4.1.32722.99.99.173744694849724904145228624619597754035
  2. Open RTSTRUCT series.

The current behavior

Series with blank description shows as tiny blank row in the dropdown.

The expected behavior

Not sure. Maybe show . In any case, the height of the corresponding item should be full, and it should be somehow more clearly indicated to the use that row exists.

System Information

N/A for this issue.

fedorov avatar Nov 24 '25 15:11 fedorov

OHI-2326

linear[bot] avatar Nov 24 '25 15:11 linear[bot]

Good catch

sedghi avatar Nov 24 '25 15:11 sedghi

Hi, good day! Can I pick up this issue? I’d also appreciate a bit more detail on the expected behavior. Thank you very much!

madhanmonishj avatar Dec 09 '25 01:12 madhanmonishj

@madhanmonishj amazing, yes please go ahead. @fedorov can chime in on the expected i guess

sedghi avatar Dec 09 '25 02:12 sedghi

I would think the expected behavior should be consistent with any other places where you face an attribute that is blank. It will take someone more familiar with various OHIF UI interfaces than me to look those. I also don't know if there is an overall design decision how to handle these situations in the UI.

At the very least, as I mentioned in the initial issue, at the very least I would expect the full height of the drop-down row corresponding to the series that has blank SeriesDescription.

fedorov avatar Dec 09 '25 19:12 fedorov

I would think the expected behavior should be consistent with any other places where you face an attribute that is blank. It will take someone more familiar with various OHIF UI interfaces than me to look those. I also don't know if there is an overall design decision how to handle these situations in the UI.

At the very least, as I mentioned in the initial issue, at the very least I would expect the full height of the drop-down row corresponding to the series that has blank SeriesDescription.

Maybe @dan-rukas might have a suggestion here?

jbocce avatar Dec 09 '25 19:12 jbocce