Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

fix: Add kheops integration into OHIF v3 again

Open wayfarer3130 opened this issue 1 year ago • 4 comments

Context

The KHEOPS url= integration got broken due to a change int he API. This PR just adds it back in.

Changes & Results

Add a dicomwebproxy example integration called kheops.js, and fix the URL call so it works.

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments, etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

wayfarer3130 avatar Aug 26 '24 15:08 wayfarer3130

Deploy Preview for ohif-platform-docs ready!

Name Link
Latest commit f621fba31c8a02e2b2a71f11795d88f23c40a2ff
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66cca3c595ee53000765a87a
Deploy Preview https://deploy-preview-4345--ohif-platform-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 26 '24 15:08 netlify[bot]

Deploy Preview for ohif-dev ready!

Name Link
Latest commit f621fba31c8a02e2b2a71f11795d88f23c40a2ff
Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66cca3c56e2bde0008e25307
Deploy Preview https://deploy-preview-4345--ohif-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 26 '24 15:08 netlify[bot]

@bradenjmorley - you can use this branch with: set APP_CONFIG=config/kheops.js yarn start to run a kheops compatible server.

wayfarer3130 avatar Aug 26 '24 15:08 wayfarer3130

Viewers    Run #4233

Run Properties:  status check passed Passed #4233  •  git commit f621fba31c: Add kheops integration into OHIF v3 again
Project Viewers
Branch Review fix/kheops-url-access
Run status status check passed Passed #4233
Run duration 02m 51s
Commit git commit f621fba31c: Add kheops integration into OHIF v3 again
Committer Bill Wallace
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 44
View all changes introduced in this branch ↗︎

cypress[bot] avatar Aug 26 '24 16:08 cypress[bot]