Viewers
Viewers copied to clipboard
fix: webpack import bugs showing warnings on import
Context
This change moves the dynamic import of modules into the plugin config so that they can be configured as desired. Then, this is used to import peer dependencies for cornerstone.
Changes & Results
Testing
Checklist
PR
- [] My Pull Request title is descriptive, accurate and follows the semantic-release format and guidelines.
Code
- [] My code has been well-documented (function documentation, inline comments, etc.)
Public Documentation Updates
- [] The documentation page has been updated as necessary for any public API additions or removals.
Tested Environment
- [] OS:
- [] Node version:
- [] Browser:
Deploy Preview for ohif-platform-docs ready!
| Name | Link |
|---|---|
| Latest commit | 33b8b2dd790efd4c995ceb428405012ce06421a9 |
| Latest deploy log | https://app.netlify.com/sites/ohif-platform-docs/deploys/66883225c07cc70008bee23b |
| Deploy Preview | https://deploy-preview-4265--ohif-platform-docs.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for ohif-dev ready!
| Name | Link |
|---|---|
| Latest commit | 33b8b2dd790efd4c995ceb428405012ce06421a9 |
| Latest deploy log | https://app.netlify.com/sites/ohif-dev/deploys/66883225bab819000825a2fe |
| Deploy Preview | https://deploy-preview-4265--ohif-dev.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Passing run #4160 ↗︎
Details:
| migration guide for peerImport/external libraries | |||
| Project: Viewers | Commit: 33b8b2dd79 |
||
| Status: Passed | Duration: 05:38 💡 | ||
| Started: Jul 5, 2024 6:14 PM | Ended: Jul 5, 2024 6:20 PM | ||