Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

[Bug] Overlay fails on viewports when used with hanging protocols

Open haldawe2 opened this issue 1 year ago • 2 comments

Describe the Bug

When using hanging protocols, and going into a study from the study browser or from a direct link, sometimes some or all of the overlays fail to render with a console error. Refreshing the page or going from one stage to another seems to work fine all the time.

image

image

Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node. at http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:1998:29 at Array.forEach () at clearUntouched (http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:1995:85) at draw (http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:1100:22) at AnnotationRenderingEngine._triggerRender (http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:44785:58) at AnnotationRenderingEngine._renderFlaggedViewports (http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:44713:26)

Steps to Reproduce

  1. Get this DX in a server. DX.zip
  2. Open the study with at least 1x2 HP (&hangingProtocolId=@ohif/mnGrid) from the study browser or using a direct link in a new tab

The current behavior

Sometimes the overlay fails to render

The expected behavior

Always renders the overlay

OS

Windows 10

Node version

20.11.1

Browser

Chrome 125.0.6422.77

haldawe2 avatar May 24 '24 10:05 haldawe2

Thanks, we will look

sedghi avatar May 24 '24 14:05 sedghi

Fixed in https://github.com/OHIF/Viewers/pull/4224

wayfarer3130 avatar Jun 21 '24 16:06 wayfarer3130

We released OHIF 3.9 which address this issue

sedghi avatar Nov 13 '24 15:11 sedghi