Viewers
Viewers copied to clipboard
Fix : Differentiate recent and all in study panel
Context
This PR tries to solve : https://github.com/OHIF/Viewers/issues/3714 It were remaining a partial implementation in which the "recent" tab and "all" tab was displaying the same content.
Changes & Results
For Primary tab => No changes For Recent => It now list studies prior to the oldest primary study with a limit time of 1y For All => It now list all patient's studies without restrictions (including primary studies)
Testing
This change does not affect Basic mode as this mode uses PanelStudyBrowserTracking, while this PR updated PanelStudyBrowser
@sedghi is there any plane to make this two sharing at least a common code base ? There a lot of duplicated code between both.
Checklist
PR
Code
- [] My code has been well-documented (function documentation, inline comments, etc.)
Public Documentation Updates
- [] The documentation page has been updated as necessary for any public API additions or removals.
Tested Environment
Chrome Latest
Deploy Preview for ohif-platform-docs ready!
Name | Link |
---|---|
Latest commit | 78e20cae7e526f18d05e3499c021891fa8d4bb38 |
Latest deploy log | https://app.netlify.com/sites/ohif-platform-docs/deploys/665620d46eebd40008247e0d |
Deploy Preview | https://deploy-preview-4085--ohif-platform-docs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for ohif-dev ready!
Name | Link |
---|---|
Latest commit | 78e20cae7e526f18d05e3499c021891fa8d4bb38 |
Latest deploy log | https://app.netlify.com/sites/ohif-dev/deploys/665620d459adf40008ec3469 |
Deploy Preview | https://deploy-preview-4085--ohif-dev.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 44.41%. Comparing base (
8a335bd
) to head (d36564e
). Report is 361 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #4085 +/- ##
==========================================
- Coverage 46.23% 44.41% -1.83%
==========================================
Files 78 80 +2
Lines 1276 1333 +57
Branches 312 327 +15
==========================================
+ Hits 590 592 +2
- Misses 548 588 +40
- Partials 138 153 +15
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm gonna open another PR for this
closing in favor of https://github.com/OHIF/Viewers/pull/4242